Bug 38767

Summary: RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, krit, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch krit: review+

Nikolas Zimmermann
Reported 2010-05-07 12:22:27 PDT
RenderSVGResourceClipper has side-effects, see on the windows bots. The results there are actually correct. Uploading a fix soon.
Attachments
Patch (19.75 KB, patch)
2010-05-07 12:27 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-05-07 12:27:55 PDT
Created attachment 55406 [details] Patch
Dirk Schulze
Comment 2 2010-05-07 12:31:55 PDT
Comment on attachment 55406 [details] Patch LGTM r=me
Nikolas Zimmermann
Comment 3 2010-05-07 12:36:31 PDT
Committed r58965: <http://trac.webkit.org/changeset/58965>
WebKit Review Bot
Comment 4 2010-05-07 13:28:58 PDT
http://trac.webkit.org/changeset/58965 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/58963 http://trac.webkit.org/changeset/58965
Dirk Schulze
Comment 5 2010-05-07 21:45:05 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/58965 might have broken Tiger Intel Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/58963 > http://trac.webkit.org/changeset/58965 None of the patch related tests fail. Not the patches fault :-)
Note You need to log in before you can comment on or make changes to this bug.