Summary: | Style cleanups in WebGL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cmarrin, dglazkov, eric, oliver, webkit.review.bot, zmo | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kenneth Russell
2010-05-07 10:54:38 PDT
Created attachment 63515 [details]
Patch
From the ChangeLog:
Cleaned up all style violations in WebGL-related files reported by check-webkit-style. No logic or other changes. Built WebKit and Chromium and ran WebGL layout tests.
Note to reviewers:
I apologize for the large size of this patch, but hopefully a quick visual inspection will show that the majority of the changes are white space adjustments to obey the indentation rules in namespaces. I can split it up if necessary, but this will prolong the pain of fixing these style violations.
Comment on attachment 63515 [details]
Patch
Holy moly that's a lot of style violations! I gave it a scan, and it looks ok. A tiny nit comment:
on *Impl suffix, I think the convention in WebKit is to use *Internal or private* prefix. So technically there's no convention, but I thought I'd mention it.
Committed r64767: <http://trac.webkit.org/changeset/64767> http://trac.webkit.org/changeset/64767 might have broken Leopard Intel Release (Tests) |