Bug 38741

Summary: Fix halfword loads on ARM
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, hausmann, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Fix halfword loads on ARM none

Gabor Loki
Reported 2010-05-07 05:06:04 PDT
The BaseIndex and ImplicitAddress are contain 32bit wide offset, but the load16 functions were working with 8 bit data (encoded in the instruction). If the offset cannot be encoded in an instruction, it should be stored in a temporary register.
Attachments
Fix halfword loads on ARM (3.75 KB, patch)
2010-05-07 05:07 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2010-05-07 05:07:16 PDT
Created attachment 55363 [details] Fix halfword loads on ARM
WebKit Commit Bot
Comment 2 2010-05-08 13:03:40 PDT
Comment on attachment 55363 [details] Fix halfword loads on ARM Clearing flags on attachment: 55363 Committed r59038: <http://trac.webkit.org/changeset/59038>
WebKit Commit Bot
Comment 3 2010-05-08 13:03:46 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 4 2010-05-12 03:41:04 PDT
Laszlo, this patch doesn't apply at all in the branch. There's no load16() function in MacroAssembler ARM. Is the branch affected by this issue at all? (Removing from the blocker list until we have something to cherry-pick :)
Gabor Loki
Comment 5 2010-05-12 03:51:26 PDT
This patch fixed both load16 functions. The load16(ImplicitAddress) is a newer function. I guess this one is missing from the Qt branch. You can add the load16(ImplicitAddress) function as well or inline its body into the load16(BaseIndex) function.
Note You need to log in before you can comment on or make changes to this bug.