Summary: | Web Inspector: Cosmetic changes in Timeline Panel. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, pfeldman, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-05-07 02:31:41 PDT
Created attachment 55351 [details]
[patch] Initial version.
Comment on attachment 55351 [details] [patch] Initial version. Rejecting patch 55351 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 18317 test cases. inspector/timeline-event-dispatch.html -> failed Exiting early after 1 failures. 14662 tests run. 265.54s total testing time 14661 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 7 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/2170072 Attachment 55351 [details] was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit.
http://trac.webkit.org/changeset/59062 might have broken GTK Linux 32-bit Release Comment on attachment 55351 [details] [patch] Initial version. > + console.log(WebInspector.linkifyResourceAsNode(record.data.url, "scripts", record.data.lineNumber, "", "")); This looks like debug, it should not go in. > + else if (typeof tooltipText !== "string" || tooltipText.length != 0) The second half of this should either be: tooltipText.length !== 0 or: !tooltipText.length Personally I'm a fan of the "!== 0" in cases of "length". But I don't think there is a style rule for this yet. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.js Committed r59080 |