Bug 38730

Summary: [chromium] Build DRT when running build-webkit --chromium
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch tkent: review+

Tony Chang
Reported 2010-05-07 01:30:37 PDT
[chromium] Build DRT when running build-webkit --chromium
Attachments
Patch (19.11 KB, patch)
2010-05-07 01:33 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (21.33 KB, patch)
2010-05-09 20:35 PDT, Tony Chang 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-05-07 01:33:36 PDT
Created attachment 55350 [details] Patch
WebKit Review Bot
Comment 2 2010-05-07 01:41:24 PDT
Attachment 55350 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2198037
Tony Chang
Comment 3 2010-05-09 20:35:46 PDT
Created attachment 55518 [details] Patch
WebKit Review Bot
Comment 4 2010-05-09 20:41:16 PDT
Attachment 55518 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2183099
Tony Chang
Comment 5 2010-05-09 23:24:46 PDT
(In reply to comment #4) > Attachment 55518 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/2183099 Is there a way for me to get the full build output? It's not clear to me why the Chromium Linux build failed. It looks like the Makefile didn't get regenerated properly. I worked fine on my Linux desktop.
Adam Barth
Comment 6 2010-05-10 08:25:48 PDT
I think that is the full build output. How did you process the gyp files? The bot doesn't runhooks. I think there's something in build-webkit that processes the gyp files. Maybe that needs to be extended to process the drt gyp?
Tony Chang
Comment 7 2010-05-10 17:00:16 PDT
(In reply to comment #6) > I think that is the full build output. How did you process the gyp files? The bot doesn't runhooks. I think there's something in build-webkit that processes the gyp files. Maybe that needs to be extended to process the drt gyp? Yes, my change requires running gclient (since it changes DEPS). Running update-webkit --chromium should do this, although it's probably easier to just run gclient sync in WebKit/WebKit/chromium.
Adam Barth
Comment 8 2010-05-10 17:14:23 PDT
Oh, I didn't notice the DEPS change. The review bot doesn't understand DEPS.
Kent Tamura
Comment 9 2010-05-10 17:49:58 PDT
Comment on attachment 55518 [details] Patch WebKit/chromium/WebKit.gyp:445 + # TODO(tony): Turn on warnings on other platforms and nit: We don't use TODO(username) in WebKit. This should be just FIXME.
Tony Chang
Comment 10 2010-05-10 20:48:00 PDT
Committed r59124: <http://trac.webkit.org/changeset/59124>
Note You need to log in before you can comment on or make changes to this bug.