Bug 38723

Summary: JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: JavaScriptCoreAssignee: Fumitoshi Ukai <ukai>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric, king_pirate11, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
eric: review+
F3A31F64D894DC06040498CD7383BEC2 none

Fumitoshi Ukai
Reported 2010-05-06 22:16:44 PDT
md5.checksum() should take a reference to output instead of returning the result by value. see https://bugs.webkit.org/show_bug.cgi?id=35572#c7
Attachments
Patch (4.23 KB, patch)
2010-05-07 00:42 PDT, Fumitoshi Ukai 		eric: review+
DetailsFormatted DiffDiff
F3A31F64D894DC06040498CD7383BEC2 (deleted)
2020-04-29 23:38 PDT, alhssan007 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2010-05-07 00:42:36 PDT
Created attachment 55347 [details] Patch
Alexey Proskuryakov
Comment 2 2010-05-07 08:35:56 PDT
Comment on attachment 55347 [details] Patch I think that checksum() should empty out the vector first, in case a non-empty one was provided by the caller.
Eric Seidel (no email)
Comment 3 2010-05-07 21:56:56 PDT
Comment on attachment 55347 [details] Patch You never mention *why* in the ChangeLog, which you should. I assume this is for performance.
Eric Seidel (no email)
Comment 4 2010-05-08 23:16:48 PDT
Attachment 55347 [details] was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit.
Fumitoshi Ukai
Comment 5 2010-05-10 00:02:51 PDT
Committed r59067: <http://trac.webkit.org/changeset/59067>
Alexey Proskuryakov
Comment 7 2020-04-30 09:18:12 PDT
The content of attachment 398040 [details] has been deleted
Note You need to log in before you can comment on or make changes to this bug.