Bug 38706

Summary: [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2010-05-06 17:21:37 PDT
With a few minor changes ImageDiff would build on every Qt supported platforms. Note sure if it make sense to run this on Symbian, but it does not hurt building it.
Attachments
proposed patch (3.80 KB, patch)
2010-05-06 17:46 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-05-06 17:46:14 PDT
Created attachment 55324 [details] proposed patch
WebKit Review Bot
Comment 2 2010-05-06 17:54:51 PDT
Attachment 55324 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/qt/ImageDiff.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2010-05-08 11:29:11 PDT
Comment on attachment 55324 [details] proposed patch Clearing flags on attachment: 55324 Committed r59031: <http://trac.webkit.org/changeset/59031>
WebKit Commit Bot
Comment 4 2010-05-08 11:29:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.