Bug 38698 – REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters

[Anders Carlsson]

Created attachment 55307 [details]
Patch

[Darin Adler]

Comment on attachment 55307 [details]
Patch

> +            if (!allowPlugins && [knownPluginMIMETypes() containsObject:MIMEType])
> +                return NO;

What if a plug-in registers for some basic MIME type like text/html?

r=me

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 55307 [details])
> > +            if (!allowPlugins && [knownPluginMIMETypes() containsObject:MIMEType])
> > +                return NO;
> 
> What if a plug-in registers for some basic MIME type like text/html?
> 

It's not possible to override basic MIME types like text/html. (In theory you're supposed to be able to override image/png etc but from looking at the code that is buggy and nondeterminate.

[Anders Carlsson]

Committed r58917: <http://trac.webkit.org/changeset/58917>

[WebKit Review Bot]

http://trac.webkit.org/changeset/58917 might have broken Qt Windows 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58912
http://trac.webkit.org/changeset/58913
http://trac.webkit.org/changeset/58914
http://trac.webkit.org/changeset/58915
http://trac.webkit.org/changeset/58916
http://trac.webkit.org/changeset/58917
http://trac.webkit.org/changeset/58918

[Eric Seidel (no email)]

I believe either this patch (http://trac.webkit.org/changeset/58917) or http://trac.webkit.org/changeset/58914 caused this failure:
http://build.webkit.org/results/Tiger%20Intel%20Release/r58918%20(11721)/webarchive/test-link-rel-icon-pretty-diff.html