Bug 38697 – REGRESSION (r58299): Replying on reddit.com no longer works

• Component: CSS
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

STEPS TO REPRODUCE:
1) Open http://www.reddit.com/r/AskReddit/comments/a7pud/whats_your_favorite_ted_talk/
2) Click the "Reply" link (you might need to be logged in for this).

EXPECTED RESULTS:
A text area opens for you to write a comment

ACTUAL:
It doesn't.

Alternatively (if you don't have a reddit account), just click "Register" link.

<rdar://problem/7931177>

[Alexey Proskuryakov]

This happens because document.querySelectorAll(".login-popup:first") no longer raises an exception.

[Alexey Proskuryakov]

Created attachment 55306 [details]
reduced test case

[Alexey Proskuryakov]

I think that this goes both ways. The new first, left and right classes are allowed outside @page rules, but also, other classes are allowed inside page rules, but they shouldn't. 

Correct (from the spec):

page :
       PAGE_SYM S* IDENT? pseudo_page? S* 
       '{' S* [ declaration | margin ]? [ ';' S* [ declaration | margin ]? ]* '}' S*
       ;

pseudo_page :
       ':' [ "left" | "right" | "first" ]
       ;

Wrong (CSSGrammar.y):

page:
    PAGE_SYM maybe_space page_selector maybe_space
...
page_selector:
    IDENT {
...
    | IDENT pseudo {
...
    | pseudo {
...
    | /* empty */ {

Note that any pseudo is allowed in page rules by the grammar here, not just pseudo_page.

[Alexey Proskuryakov]

Created attachment 55318 [details]
naive fix

[Geoffrey Garen]

Comment on attachment 55318 [details]
naive fix

r=me

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/58922>. Add a FIXME comment, as suggested by Mitz.

[Darin Adler]

Comment on attachment 55318 [details]
naive fix

> +    document.querySelectorAll(".login-popup:first");

I'd be happier if you included test cases for all three of the affected pseudo classes.

[Yuzo Fujishima]

Sorry for the regression and thank you for the fix.

[Yuzo Fujishima]

I'll address the grammar issue under a separate bug.

[Alexey Proskuryakov]

*** Bug 38729 has been marked as a duplicate of this bug. ***

[visnu pitiyanuvath]

*** Bug 38499 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 38804 has been marked as a duplicate of this bug. ***