Bug 38663

Summary: SVGFont's VKern implementation missing
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Dirk Schulze
Reported 2010-05-06 10:46:06 PDT
SVGFont's VKern implementation missing
Attachments
Patch (73.56 KB, patch)
2010-05-06 10:59 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (76.44 KB, patch)
2010-05-08 00:22 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-05-06 10:59:37 PDT
Created attachment 55269 [details] Patch
WebKit Review Bot
Comment 2 2010-05-06 11:04:40 PDT
Attachment 55269 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/SVGRootInlineBox.cpp:365: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2010-05-06 11:34:15 PDT
Attachment 55269 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2227020
WebKit Review Bot
Comment 4 2010-05-06 12:16:14 PDT
Attachment 55269 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2203018
Dirk Schulze
Comment 5 2010-05-08 00:22:00 PDT
Created attachment 55465 [details] Patch
WebKit Review Bot
Comment 6 2010-05-08 00:26:02 PDT
Attachment 55465 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/SVGRootInlineBox.cpp:365: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Schulze
Comment 7 2010-05-08 01:18:52 PDT
(In reply to comment #6) > Attachment 55465 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" > exit_code: 1 > WebCore/rendering/SVGRootInlineBox.cpp:365: Tests for true/false, > null/non-null, and zero/non-zero should all be done without equality > comparisons. [readability/comparison_to_zero] [5] > Total errors found: 1 in 35 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. The != 0 check is needed here, since the results are allowed to be negative.
Nikolas Zimmermann
Comment 8 2010-05-08 01:43:14 PDT
Comment on attachment 55465 [details] Patch Looks fantastic, r=me.
WebKit Review Bot
Comment 9 2010-05-08 02:33:03 PDT
http://trac.webkit.org/changeset/59010 might have broken Qt Linux Release
Eric Seidel (no email)
Comment 10 2010-05-08 23:16:26 PDT
Attachment 55465 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Dirk Schulze
Comment 11 2010-05-09 23:05:37 PDT
Comment on attachment 55465 [details] Patch Landed in http://trac.webkit.org/changeset/59010. Buildfix + new Baselines landed in: 59011,59012,59014,59018. Clearing review flag.
Note You need to log in before you can comment on or make changes to this bug.