Bug 38659

Summary: Improve performance of single character string compares
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2010-05-06 10:39:12 PDT
Improve performance of single character string compares
Attachments
Patch (415.17 KB, patch)
2010-05-06 10:45 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-05-06 10:45:13 PDT
Created attachment 55262 [details] Patch
Oliver Hunt
Comment 2 2010-05-06 10:45:49 PDT
Patch is giant due to testcase results -- actual patch is only ~30k
Geoffrey Garen
Comment 3 2010-05-06 11:03:15 PDT
Let's call emit_op_jxlesseq emit_op_jlesseq and have invert default to false. I'm concerned that a 3 second test might hang some bots. Maybe you can split the test up, or merge the functions into a larger function, so there are fewer parsing/compilation/call passes.
Geoffrey Garen
Comment 4 2010-05-06 11:03:26 PDT
Comment on attachment 55262 [details] Patch r=me
Oliver Hunt
Comment 5 2010-05-06 12:40:10 PDT
Committed r58902: <http://trac.webkit.org/changeset/58902>
WebKit Review Bot
Comment 6 2010-05-06 12:48:56 PDT
http://trac.webkit.org/changeset/58902 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release
Eric Seidel (no email)
Comment 7 2010-05-06 19:45:38 PDT
I think this caused timeouts on the Gtk Bot: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r58925%20(5593)/results.html
Eric Seidel (no email)
Comment 8 2010-05-06 19:58:37 PDT
My apologies. I was mistaken. :(
Note You need to log in before you can comment on or make changes to this bug.