| Summary: | Improve performance of single character string compares | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, ggaren, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Oliver Hunt
2010-05-06 10:39:12 PDT
Created attachment 55262 [details]
Patch
Patch is giant due to testcase results -- actual patch is only ~30k Let's call emit_op_jxlesseq emit_op_jlesseq and have invert default to false. I'm concerned that a 3 second test might hang some bots. Maybe you can split the test up, or merge the functions into a larger function, so there are fewer parsing/compilation/call passes. Comment on attachment 55262 [details]
Patch
r=me
Committed r58902: <http://trac.webkit.org/changeset/58902> http://trac.webkit.org/changeset/58902 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release I think this caused timeouts on the Gtk Bot: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r58925%20(5593)/results.html My apologies. I was mistaken. :( |