Summary: | Potential crash in EventHandler::handleTouchEvent | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ben Murdoch <benm> | ||||
Component: | WebCore Misc. | Assignee: | Ben Murdoch <benm> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | android-webkit-unforking, commit-queue, gdk, hausmann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 32485 | ||||||
Attachments: |
|
Description
Ben Murdoch
2010-05-06 08:17:11 PDT
Created attachment 55263 [details]
Proposed Patch.
Comment on attachment 55263 [details] Proposed Patch. > - if (!touchTarget) > + if (!touchTarget.get()) This get() should not be required. I'm sad that we can't make a test for this. In the bad old days we'd take changes like this without tests a lot. The obviousness of the "simple logic error" is not an important criterion. r=me even without a test (In reply to comment #2) > (From update of attachment 55263 [details]) > > - if (!touchTarget) > > + if (!touchTarget.get()) > > This get() should not be required. > > I'm sad that we can't make a test for this. In the bad old days we'd take > changes like this without tests a lot. The obviousness of the "simple logic > error" is not an important criterion. > > r=me even without a test Totally agree about the tests. I really wanted to have a test for this and have been trying to get a concrete set of steps for a consistent reproduction over the past day or two but unfortunately didn't get there. In the end I decided it was more important to get the fix into the tree and move on. :) Thanks for the review, setting cq+. Comment on attachment 55263 [details] Proposed Patch. Clearing flags on attachment: 55263 Committed r58948: <http://trac.webkit.org/changeset/58948> All reviewed patches have been landed. Closing bug. |