Bug 38643

Summary:

Web Inspector: Timeline: Confused use case. See screenshot.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, pfeldman, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

38726

Bug Blocks:

Attachments:

Description	Flags
screenshot	none
screenshot. fixed version.	none
[patch] initial version.	none
[patch] Second iteration.	pfeldman: review+

Ilya Tikhonovsky

Reported 2010-05-06 07:09:16 PDT

If some record is not in visible area then it's expand element also is not visible even if it has children in visible area.

Attachments
screenshot (71.31 KB, image/png) 2010-05-06 07:11 PDT, Ilya Tikhonovsky	no flags	Details
screenshot. fixed version. (64.90 KB, image/png) 2010-05-06 07:19 PDT, Ilya Tikhonovsky	no flags	Details
[patch] initial version. (14.86 KB, patch) 2010-05-06 07:24 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
[patch] Second iteration. (4.58 KB, patch) 2010-05-07 01:02 PDT, Ilya Tikhonovsky	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2010-05-06 07:11:15 PDT

Created attachment 55233 [details] screenshot

Ilya Tikhonovsky

Comment 2 2010-05-06 07:19:36 PDT

Created attachment 55234 [details] screenshot. fixed version.

Ilya Tikhonovsky

Comment 3 2010-05-06 07:24:52 PDT

Created attachment 55235 [details] [patch] initial version. expandElement code was extracted into separate class. Inner Function Call event of TimerFire event will be merged into TimerFire even if it isn't the only child.

Pavel Feldman

Comment 4 2010-05-06 23:08:01 PDT

Comment on attachment 55235 [details] [patch] initial version. Please split the patch into two: orphan expanders and list expanders. Orphan expanders part looks good to me as is, but the list expanders patch needs a screenshot!

Ilya Tikhonovsky

Comment 5 2010-05-07 01:02:45 PDT

Created attachment 55349 [details] [patch] Second iteration. The patch should be landed after https://bugs.webkit.org/show_bug.cgi?id=38726 The idea: If a record from invisible upper gap has children and it's last child is visible then we create ExpandElement for this invisible row.

Eric Seidel (no email)

Comment 6 2010-05-08 23:13:36 PDT

Attachment 55349 [details] was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit.

Ilya Tikhonovsky

Comment 7 2010-05-09 14:02:09 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js Committed r59059

Note You need to log in before you can comment on or make changes to this bug.