| Summary: | Web Inspector: Timeline: Confused use case. See screenshot. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric, pfeldman, timothy, yurys | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 38726 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ilya Tikhonovsky
2010-05-06 07:09:16 PDT
Created attachment 55233 [details]
screenshot
Created attachment 55234 [details]
screenshot. fixed version.
Created attachment 55235 [details]
[patch] initial version.
expandElement code was extracted into separate class.
Inner Function Call event of TimerFire event will be merged into TimerFire even if it isn't the only child.
Comment on attachment 55235 [details]
[patch] initial version.
Please split the patch into two: orphan expanders and list expanders. Orphan expanders part looks good to me as is, but the list expanders patch needs a screenshot!
Created attachment 55349 [details] [patch] Second iteration. The patch should be landed after https://bugs.webkit.org/show_bug.cgi?id=38726 The idea: If a record from invisible upper gap has children and it's last child is visible then we create ExpandElement for this invisible row. Attachment 55349 [details] was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js Committed r59059 |