Bug 38619

Summary: Delete obsolete CanvasNumberArray
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, levin, mdelaney7, oliver, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch levin: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-05-05 17:53:14 PDT
The CanvasNumberArray class and associated JavaScript bindings are obsolete and should be deleted. Their continued presence makes it difficult to identify which classes need to be changed when making fixes to the WebGL<T>Arrays.
Attachments
Patch (8.90 KB, patch)
2010-08-11 18:59 PDT, Kenneth Russell 		levin: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-08-11 18:59:50 PDT
Created attachment 64180 [details] Patch Deleted unreferenced code. Built WebKit and Chromium to test.
David Levin
Comment 2 2010-08-11 19:37:22 PDT
Comment on attachment 64180 [details] Patch Note that you'll likely break Android's build because it looks like Android.mk and a few other Android.*.mk files refer to *CanvasNumberArray*. If you wish to fix those up as well, it would be nice (but since they have no buildbot and since they add more build files instead of using the gyp files, I won't force the issue).
Kenneth Russell
Comment 3 2010-08-12 16:55:53 PDT
(In reply to comment #2) > (From update of attachment 64180 [details]) > Note that you'll likely break Android's build because it looks like Android.mk and a few other Android.*.mk files refer to *CanvasNumberArray*. > > If you wish to fix those up as well, it would be nice (but since they have no buildbot and since they add more build files instead of using the gyp files, I won't force the issue). Thanks for pointing this out. I'll delete these references in the committed version of the patch.
Kenneth Russell
Comment 4 2010-08-12 17:12:46 PDT
Committed r65285: <http://trac.webkit.org/changeset/65285>
Note You need to log in before you can comment on or make changes to this bug.