Bug 38593

Summary: Web Inspector: Line Numbers should be Aligned with the Source Code Line
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before - Centered
none
[IMAGE] After - Aligned to Top
none
[PATCH] Set "vertical-align: top" for line numbers none

Description Joseph Pecoraro 2010-05-05 10:32:21 PDT
If there is an error bubble in the source code, the line number is currently shown centered. This is confusing if the error bubble is in javascript and the user wants to set a breakpoint.
Comment 1 Joseph Pecoraro 2010-05-05 10:32:52 PDT
Created attachment 55135 [details]
[IMAGE] Before - Centered
Comment 2 Joseph Pecoraro 2010-05-05 10:33:18 PDT
Created attachment 55136 [details]
[IMAGE] After - Aligned to Top
Comment 3 Joseph Pecoraro 2010-05-05 10:38:21 PDT
Created attachment 55137 [details]
[PATCH] Set "vertical-align: top" for line numbers

Do these type of diffs work with commit-queue yet?
Comment 4 WebKit Commit Bot 2010-05-05 21:29:01 PDT
Comment on attachment 55137 [details]
[PATCH] Set "vertical-align: top" for line numbers

Clearing flags on attachment: 55137

Committed r58857: <http://trac.webkit.org/changeset/58857>
Comment 5 WebKit Commit Bot 2010-05-05 21:29:07 PDT
All reviewed patches have been landed.  Closing bug.