Bug 38589

Summary: [chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace
Product: WebKit Reporter: Hans Wennborg <hans>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Hans Wennborg
Reported 2010-05-05 08:54:45 PDT
Add quota parameter to WebStorageNamespace::createSessionStorageNamespace. See http://crbug.com/42740.
Attachments
Patch (2.71 KB, patch)
2010-05-05 10:13 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (2.71 KB, patch)
2010-05-05 10:23 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2010-05-05 10:13:04 PDT
Created attachment 55133 [details] Patch
Jeremy Orlow
Comment 2 2010-05-05 10:17:54 PDT
Comment on attachment 55133 [details] Patch Please fix and upload another patch. I'll commit queue + that one (so it'll get committed to WebKit). > diff --git a/WebKit/chromium/ChangeL > // If path is empty, data will not persist. You should call delete on the returned > // object when you're finished. > WEBKIT_API static WebStorageNamespace* createLocalStorageNamespace(const WebString& backingDirectoryPath, unsigned quota); > - WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace(); > + Don't need this newline. > + WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace(unsigned quota); > + Don't need this new lines.
Hans Wennborg
Comment 3 2010-05-05 10:23:50 PDT
Created attachment 55134 [details] Patch
Jeremy Orlow
Comment 4 2010-05-05 10:26:38 PDT
Comment on attachment 55134 [details] Patch r=me
WebKit Commit Bot
Comment 5 2010-05-05 11:14:35 PDT
Comment on attachment 55134 [details] Patch Clearing flags on attachment: 55134 Committed r58828: <http://trac.webkit.org/changeset/58828>
WebKit Commit Bot
Comment 6 2010-05-05 11:14:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.