Bug 38577

Summary: [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 38576    
Attachments:
Description Flags
Patch
none
Small bug caught while refactoring, $custom variable was never initialized. none

Xan Lopez
Reported 2010-05-05 04:37:25 PDT
In order to add support for EventListeners. First step is to move the code that generates just one property out of the parent function.
Attachments
Patch (15.45 KB, patch)
2010-05-05 04:42 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Small bug caught while refactoring, $custom variable was never initialized. (3.71 KB, patch)
2010-05-05 04:58 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-05-05 04:42:13 PDT
Created attachment 55107 [details] Patch
Xan Lopez
Comment 2 2010-05-05 04:58:13 PDT
Created attachment 55109 [details] Small bug caught while refactoring, $custom variable was never initialized.
Eric Seidel (no email)
Comment 3 2010-05-05 21:51:18 PDT
Holy bee-geez-us. Can we maybe make that factored out method into smaller-yet factorings?
Eric Seidel (no email)
Comment 4 2010-05-05 21:52:12 PDT
Comment on attachment 55107 [details] Patch This is mostly a rubber-stamp. We need to further sane-ify this code.
Eric Seidel (no email)
Comment 5 2010-05-05 21:52:45 PDT
Comment on attachment 55109 [details] Small bug caught while refactoring, $custom variable was never initialized. rs=me.
Xan Lopez
Comment 6 2010-05-06 01:12:07 PDT
(In reply to comment #3) > Holy bee-geez-us. Can we maybe make that factored out method into smaller-yet > factorings? It's good that you didn't see the original patch I had to work with ;) GenerateProperty seems to me to be at almost sane levels by now, there's other parts of the script that are in worse shape. But in general, yeah, I will continue (trying) to improve this code.
Xan Lopez
Comment 7 2010-05-06 01:12:38 PDT
Comment on attachment 55107 [details] Patch Landed in r58870
Xan Lopez
Comment 8 2010-05-06 01:12:56 PDT
Comment on attachment 55109 [details] Small bug caught while refactoring, $custom variable was never initialized. Landed in r58871.
Xan Lopez
Comment 9 2010-05-06 01:13:25 PDT
All patches landed, closing.
Note You need to log in before you can comment on or make changes to this bug.