Bug 38567

Summary: Web Inspector: FontView needs Cleanup
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] FontView Before
none
[IMAGE] FontView After
none
[PATCH] Proposed Fix - FontView Cleanup none

Joseph Pecoraro
Reported 2010-05-05 00:17:44 PDT
When refactoring SourceView / ImageView it looks like FontView was missed. Also, make calculation based on a slightly narrower area to prevent lines from widowing.
Attachments
[IMAGE] FontView Before (149.17 KB, image/png)
2010-05-05 00:19 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] FontView After (172.96 KB, image/png)
2010-05-05 00:19 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix - FontView Cleanup (5.57 KB, patch)
2010-05-05 00:25 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-05-05 00:19:30 PDT
Created attachment 55091 [details] [IMAGE] FontView Before
Joseph Pecoraro
Comment 2 2010-05-05 00:19:53 PDT
Created attachment 55092 [details] [IMAGE] FontView After
Joseph Pecoraro
Comment 3 2010-05-05 00:25:29 PDT
Created attachment 55093 [details] [PATCH] Proposed Fix - FontView Cleanup The patch looks a lot scarier then it actually is. - moved some code down from the constructor to contentTabSelected - changed some variables to const for clarity - cached the number of lines in this._lineCount (we may need to remove this if we allow the users to edit the text on the fly! see bug 16232!)
WebKit Commit Bot
Comment 4 2010-05-05 00:57:17 PDT
Comment on attachment 55093 [details] [PATCH] Proposed Fix - FontView Cleanup Clearing flags on attachment: 55093 Committed r58805: <http://trac.webkit.org/changeset/58805>
WebKit Commit Bot
Comment 5 2010-05-05 00:57:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.