Summary: | Web Inspector: FontView needs Cleanup | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2010-05-05 00:17:44 PDT
Created attachment 55091 [details]
[IMAGE] FontView Before
Created attachment 55092 [details]
[IMAGE] FontView After
Created attachment 55093 [details] [PATCH] Proposed Fix - FontView Cleanup The patch looks a lot scarier then it actually is. - moved some code down from the constructor to contentTabSelected - changed some variables to const for clarity - cached the number of lines in this._lineCount (we may need to remove this if we allow the users to edit the text on the fly! see bug 16232!) Comment on attachment 55093 [details] [PATCH] Proposed Fix - FontView Cleanup Clearing flags on attachment: 55093 Committed r58805: <http://trac.webkit.org/changeset/58805> All reviewed patches have been landed. Closing bug. |