Bug 38553

Summary: new-run-webkit-tests: disable threading on macs by default
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: cjerdonek, dglazkov, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
eric: review+, eric: commit-queue-
add log message
none
add unit tests for the change to run_webkit_tests none

Dirk Pranke
Reported 2010-05-04 16:17:18 PDT
We are currently trying to diagnose what appear to be several concurrency-related hangs on the Chromium bots. Several bots (Chromium WebKit Mac (webkit.org) canary, Chromium WebKit Mac, Chromium WebKit Mac (dbg)(3) ) seem to be hanging more than 25% of the time. Until we can diagnose what's going on better, we should consider disabling concurrency by default on the Chromium Mac ports. Most of the bots run two threads in parallel, so this will near-double the cycle time for the layout tests on them.
Attachments
patch (2.19 KB, patch)
2010-05-04 16:25 PDT, Dirk Pranke 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
add log message (2.46 KB, patch)
2010-05-04 16:44 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
add unit tests for the change to run_webkit_tests (6.86 KB, patch)
2010-05-04 17:07 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-05-04 16:19:32 PDT
Another possibility would be to try changing DEPS to point to an older version of WebKitTools on those bots and see if the hangs go away.
Dirk Pranke
Comment 2 2010-05-04 16:25:18 PDT
Created attachment 55069 [details] patch
Eric Seidel (no email)
Comment 3 2010-05-04 16:27:39 PDT
Comment on attachment 55069 [details] patch We really should have a unit test for the run_webkit_tests.py change. This seems OK or now. Unfortunately it means we'll stop getting crash/hang data, but hopefully we have enough and can repro locally anyway. Seems we should log to the console when we do this override.
Eric Seidel (no email)
Comment 4 2010-05-04 16:36:50 PDT
Comment on attachment 55069 [details] patch Please fix the mentioned nits. If you aren't going to unit test this we should at least mention why in the ChangeLog.
Dirk Pranke
Comment 5 2010-05-04 16:44:17 PDT
Created attachment 55070 [details] add log message
Dirk Pranke
Comment 6 2010-05-04 17:07:34 PDT
Created attachment 55075 [details] add unit tests for the change to run_webkit_tests
Dirk Pranke
Comment 7 2010-05-04 17:17:06 PDT
Committed r58789: <http://trac.webkit.org/changeset/58789>
Eric Seidel (no email)
Comment 8 2010-05-04 18:44:43 PDT
Thanks for the tests!
Note You need to log in before you can comment on or make changes to this bug.