Summary: | new-run-webkit-tests: disable threading on macs by default | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cjerdonek, dglazkov, eric, ojan, tony | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Dirk Pranke
2010-05-04 16:17:18 PDT
Another possibility would be to try changing DEPS to point to an older version of WebKitTools on those bots and see if the hangs go away. Created attachment 55069 [details]
patch
Comment on attachment 55069 [details]
patch
We really should have a unit test for the run_webkit_tests.py change.
This seems OK or now. Unfortunately it means we'll stop getting crash/hang data, but hopefully we have enough and can repro locally anyway.
Seems we should log to the console when we do this override.
Comment on attachment 55069 [details]
patch
Please fix the mentioned nits. If you aren't going to unit test this we should at least mention why in the ChangeLog.
Created attachment 55070 [details]
add log message
Created attachment 55075 [details]
add unit tests for the change to run_webkit_tests
Committed r58789: <http://trac.webkit.org/changeset/58789> Thanks for the tests! |