Bug 38549 – [WebKit2] The web process doesn't need to paint when the web view is hidden.

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

[WebKit2] The web process doesn't need to paint when the web view is hidden.

[Anders Carlsson]

Created attachment 55050 [details]
Patch

Comment on attachment 55050 [details]
Patch

> +void DrawingAreaUpdateChunk::suspendPainting()
> +{
> +    ASSERT(m_shouldPaint);

Do you really want to assert this?

> +void DrawingAreaUpdateChunk::resumePainting()
> +{
> +    ASSERT(!m_shouldPaint);

Do you really want to assert this?

r=me if you change “paint” to “update” and “painting” to “updating”.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 55050 [details])
> > +void DrawingAreaUpdateChunk::suspendPainting()
> > +{
> > +    ASSERT(m_shouldPaint);
> 
> Do you really want to assert this?
> 

I figured it wouldn't hurt! If it's a problem we can always remove it later.

> > +void DrawingAreaUpdateChunk::resumePainting()
> > +{
> > +    ASSERT(!m_shouldPaint);
> 
> Do you really want to assert this?
> 

I figured it wouldn't hurt! If it's a problem we can always remove it later.

> r=me if you change “paint” to “update” and “painting” to “updating”.

Will do, thanks!

[Anders Carlsson]

Committed r58781: <http://trac.webkit.org/changeset/58781>