Bug 38545

Summary:

extract-localizable-strings script miss files when skip directories are specified

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Tools / Tests

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	darin: review+, timothy: commit-queue-

Timothy Hatcher

Reported 2010-05-04 14:05:10 PDT

The extract-localizable-strings script's use of -prune gets lumped into the first match causing it to skip "*.h" files. This caused <rdar://problem/7940701>. We need to fix the arguments we pass to find in this script.

Attachments
Proposed patch (3.60 KB, patch) 2010-05-04 14:17 PDT, Timothy Hatcher	darin: review+ timothy: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2010-05-04 14:12:32 PDT

I think we want to have this say "-prune -false -o" instead of just "-prune".

Timothy Hatcher

Comment 2 2010-05-04 14:17:41 PDT

Created attachment 55048 [details] Proposed patch

Timothy Hatcher

Comment 3 2010-05-04 14:23:21 PDT

It seems to work this way, since -prune is an action it does not cause the results to print (no implict -print action for those.) That is my understanding how it works.

Timothy Hatcher

Comment 4 2010-05-04 14:25:03 PDT

But that dosen't match what the man page says: If none of -exec, -ls, -print, -print0, or -ok is specified, the given expression shall be effectively replaced by ( given expression ) -print.

Timothy Hatcher

Comment 5 2010-05-04 14:26:44 PDT

Doing "-prune -false" has the same effect as "-prune".

Timothy Hatcher

Comment 6 2010-05-04 21:27:19 PDT

Landed in r58777.

Note You need to log in before you can comment on or make changes to this bug.