Bug 38544

Summary:

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, commit-queue, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Steve Block

Reported 2010-05-04 13:48:15 PDT

MAC_JAVA_BRIDGE is used on both Mac and ANDROID. It should be renamed JAVA_BRIDGE.

Attachments
Patch (17.27 KB, patch) 2010-05-04 15:36 PDT, Steve Block	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-05-04 15:36:20 PDT

Created attachment 55061 [details] Patch

Eric Seidel (no email)

Comment 2 2010-05-05 21:54:26 PDT

Comment on attachment 55061 [details] Patch OK. But why not JNI_BRIDGE to match the class names?

Steve Block

Comment 3 2010-05-06 05:56:36 PDT

> But why not JNI_BRIDGE to match the class names? The classes are prefixed with 'Java', though it's true that some of the files are prefixed with 'JNI'. I think that 'Java' makes more sense, as it's the language to which we're bridging.

WebKit Commit Bot

Comment 4 2010-05-06 07:10:03 PDT

Comment on attachment 55061 [details] Patch Clearing flags on attachment: 55061 Committed r58878: <http://trac.webkit.org/changeset/58878>

WebKit Commit Bot

Comment 5 2010-05-06 07:10:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.