Bug 38542

Summary: Web Inspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
screenshot.
none
[patch] Initial version.
pfeldman: review+
[patch] landed version. none

Ilya Tikhonovsky
Reported 2010-05-04 13:40:59 PDT
Created attachment 55041 [details] screenshot. Direct link to resources should be used as 'details' part of record for all suitable record types. As far as we definitely have a single child FunctionCall event for each TimerFire event we should propagate FunctionCall record's data to its parent TimerFire record.
Attachments
screenshot. (45.35 KB, image/png)
2010-05-04 13:40 PDT, Ilya Tikhonovsky 		no flags
Details
[patch] Initial version. (19.53 KB, patch)
2010-05-04 13:48 PDT, Ilya Tikhonovsky 		pfeldman: review+
DetailsFormatted DiffDiff
[patch] landed version. (19.80 KB, patch)
2010-05-05 04:36 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-05-04 13:48:45 PDT
Created attachment 55042 [details] [patch] Initial version.
Pavel Feldman
Comment 2 2010-05-04 23:44:37 PDT
Comment on attachment 55042 [details] [patch] Initial version. WebCore/inspector/front-end/TimelinePanel.js:1002 + WebInspector.TimelinePanel.FormattedRecord.PopupContentHelper = function(title) This could be WebInspector.TimelinePanel.PopupContentHelper or WebInspector.TimelinePopupContentHelper. No need to create nesting that deep. Same for FromattedRecord itself. Please fix before landing!
Ilya Tikhonovsky
Comment 3 2010-05-05 04:31:02 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js Committed r58809
Ilya Tikhonovsky
Comment 4 2010-05-05 04:36:37 PDT
Created attachment 55106 [details] [patch] landed version. PopupContentHelper was renamed. 'details' part of Timer related records was adjusted for WebKit case where we have no information about caller and callback function.
Note You need to log in before you can comment on or make changes to this bug.