| Summary: | Web Inspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | pfeldman, timothy, yurys | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 55042 [details]
[patch] Initial version.
Comment on attachment 55042 [details]
[patch] Initial version.
WebCore/inspector/front-end/TimelinePanel.js:1002
+ WebInspector.TimelinePanel.FormattedRecord.PopupContentHelper = function(title)
This could be WebInspector.TimelinePanel.PopupContentHelper or WebInspector.TimelinePopupContentHelper. No need to create nesting that deep. Same for FromattedRecord itself.
Please fix before landing!
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js Committed r58809 Created attachment 55106 [details]
[patch] landed version.
PopupContentHelper was renamed.
'details' part of Timer related records was adjusted for WebKit case where we have no information about caller and callback function.
|
Created attachment 55041 [details] screenshot. Direct link to resources should be used as 'details' part of record for all suitable record types. As far as we definitely have a single child FunctionCall event for each TimerFire event we should propagate FunctionCall record's data to its parent TimerFire record.