Bug 38521

Summary: New FileSystemPOSIX functions cause linker errors on Android
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, kinuko
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Steve Block
Reported 2010-05-04 08:20:48 PDT
Android uses FileSystemPOSIX.cpp but also uses additional functions in FileSystemAndroid.cpp. http://trac.webkit.org/changeset/57182 added a number of new functions to FileSystemPOSIX.cpp, of which two (closeFile and writeToFile) are already present in FileSystemAndroid.cpp. This causes link errors on Android due to multiply defined symbols.
Attachments
Patch (1.96 KB, patch)
2010-05-04 08:45 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-05-04 08:45:47 PDT
Created attachment 55022 [details] Patch
WebKit Commit Bot
Comment 2 2010-05-04 14:02:53 PDT
Comment on attachment 55022 [details] Patch Clearing flags on attachment: 55022 Committed r58774: <http://trac.webkit.org/changeset/58774>
WebKit Commit Bot
Comment 3 2010-05-04 14:02:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.