Bug 38513

Summary: Split SVGCharacterLayoutInfo in smaller pieces
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch krit: review+

Description Nikolas Zimmermann 2010-05-04 03:32:01 PDT 
SVGCharacterLayoutInfo is convoluted, it should be split up.
Comment 1 Nikolas Zimmermann 2010-05-04 03:50:09 PDT 
Two style errors in the upcoming patch, on purpose.
Need to check whether floats are equal to 0.0f, can't use ! operator.
Comment 2 Nikolas Zimmermann 2010-05-04 03:54:58 PDT 
Created attachment 55007 [details]
Patch
Comment 3 WebKit Review Bot 2010-05-04 03:57:29 PDT 
Attachment 55007 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/SVGCharacterLayoutInfo.cpp:171:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/SVGCharacterLayoutInfo.cpp:172:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dirk Schulze 2010-05-04 04:17:34 PDT 
Comment on attachment 55007 [details]
Patch

LGTM r=me
Comment 5 Nikolas Zimmermann 2010-05-04 05:08:29 PDT 
Committed r58751: <http://trac.webkit.org/changeset/58751>