Bug 38511

Summary: [Qt] Remove WinCE endian dedection.
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, laszlo.gombos, ossy, skyul, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 37434    
Bug Blocks:    
Attachments:
Description Flags
The patch none

Patrick R. Gansterer
Reported 2010-05-04 02:01:59 PDT
See patch.
Attachments
The patch (1.43 KB, patch)
2010-05-04 02:03 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-05-04 02:03:20 PDT
Created attachment 55003 [details] The patch
Laszlo Gombos
Comment 2 2010-05-04 10:43:01 PDT
Patrick, the change looks good to me. Have you had a chance to test it on WinCE?
Patrick R. Gansterer
Comment 3 2010-05-04 10:48:38 PDT
(In reply to comment #2) > Patrick, the change looks good to me. Have you had a chance to test it on > WinCE? No, I didn't. (It takes sooo much time) I can compile it with this patch if it's necessary, but I don't think so. ;-)
Laszlo Gombos
Comment 4 2010-05-04 10:59:09 PDT
As we do not have a buildbot for WinCE I would feel better if we could actually test this build change. Only the QtWebKit port on WinCE is impacted. Should we find someone else to test this with QtWebKit ?
Patrick R. Gansterer
Comment 5 2010-05-04 11:03:20 PDT
(In reply to comment #4) > As we do not have a buildbot for WinCE I would feel better if we could actually > test this build change. Only the QtWebKit port on WinCE is impacted. > > Should we find someone else to test this with QtWebKit ? I'll try to get it running, but I had many troubles compiling QtWebKit for WinCE directly from svn trunk the last time. It doesn't work as nice as from a Qt release. ;-)
Laszlo Gombos
Comment 6 2010-05-05 13:09:22 PDT
Comment on attachment 55003 [details] The patch r+ for the patch, but cq- until it is confirmed that this does not breaks the build. Thanks for the clean-up, this moves the code to the right direction.
Jesus Sanchez-Palencia
Comment 7 2010-05-12 06:49:24 PDT
Triaged but I'm not adding it as QtWebKit 2.0 blocker as I don't know if you want this.
Patrick R. Gansterer
Comment 8 2010-05-14 02:21:01 PDT
Comment on attachment 55003 [details] The patch It took a lot of time to compile it out of trunk for WinCE, but it works with this patch.
WebKit Commit Bot
Comment 9 2010-05-17 01:11:21 PDT
Comment on attachment 55003 [details] The patch Clearing flags on attachment: 55003 Committed r59600: <http://trac.webkit.org/changeset/59600>
WebKit Commit Bot
Comment 10 2010-05-17 01:11:26 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2010-05-17 01:40:54 PDT
http://trac.webkit.org/changeset/59600 might have broken Qt Linux ARMv7 Release The following changes are on the blame list: http://trac.webkit.org/changeset/59600 http://trac.webkit.org/changeset/59599
Eric Seidel (no email)
Comment 12 2010-05-17 01:43:33 PDT
Sorry. The qt builders just got disconnected. I think we may need to remove them from the sheriff-bot watch until they can get a better internet connection.
Note You need to log in before you can comment on or make changes to this bug.