Bug 38483

Summary: Implement PageClient::isPageVisible on Windows.
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Anders Carlsson
Reported 2010-05-03 13:00:03 PDT
Implement PageClient::isPageVisible on Windows.
Attachments
Patch (2.27 KB, patch)
2010-05-03 13:06 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-05-03 13:06:00 PDT
Created attachment 54956 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-05-03 13:10:16 PDT
Comment on attachment 54956 [details] Patch Is it possible for m_window to be null? The FIXME seems incorrect if it's possible for m_window to be a top-level window. You could add a FIXME about checking if the window is clipped out of view. r=me
Anders Carlsson
Comment 3 2010-05-03 13:11:59 PDT
(In reply to comment #2) > (From update of attachment 54956 [details]) > Is it possible for m_window to be null? > Nope. > The FIXME seems incorrect if it's possible for m_window to be a top-level > window. It will never be a top-level window. > > You could add a FIXME about checking if the window is clipped out of view. In that case I think we might still want to update the backing store; this is more to stop updates from web views in hidden tabs from happening. > > r=me Thanks!
Anders Carlsson
Comment 4 2010-05-03 13:19:58 PDT
Committed r58697: <http://trac.webkit.org/changeset/58697>
Note You need to log in before you can comment on or make changes to this bug.