Bug 38482

Summary: wx port: mac lacks complex text support
Product: WebKit Reporter: Kevin Watters <kevinwatters>
Component: WebKit wxAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kevino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Build and use Mac's ComplexTextController to support complex text in wx kevino: review+, kevino: commit-queue-

Kevin Watters
Reported 2010-05-03 12:39:28 PDT
Created attachment 54955 [details] Build and use Mac's ComplexTextController to support complex text in wx We could use the Mac implementation of ComplexTextController to support complex scripts on wxMac.
Attachments
Build and use Mac's ComplexTextController to support complex text in wx (34.17 KB, patch)
2010-05-03 12:39 PDT, Kevin Watters 		kevino: review+
kevino: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-05-03 12:48:25 PDT
Attachment 54955 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/SimpleFontData.h:128: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kevin Ollivier
Comment 2 2010-05-03 15:32:20 PDT
Landed in r58707, thanks!
WebKit Review Bot
Comment 3 2010-05-03 16:51:47 PDT
http://trac.webkit.org/changeset/58707 might have broken Qt Linux Release minimal
Note You need to log in before you can comment on or make changes to this bug.