Bug 38480

Summary:

wx port: scheduleDispatchFunctionsOnMainThread is unimplemented

Product:

WebKit

Reporter:

Kevin Watters <kevinwatters>

Component:

WebKit wx

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kevino, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
implements scheduleDispatchFunctionsOnMainThread	kevino: review+, kevino: commit-queue-

Kevin Watters

Reported 2010-05-03 12:29:09 PDT

Created attachment 54953 [details] implements scheduleDispatchFunctionsOnMainThread The wx port needs an implementation for scheduleDispatchFunctionsOnMainThread in MainThreadWx.cpp.

Attachments
implements scheduleDispatchFunctionsOnMainThread (1.65 KB, patch) 2010-05-03 12:29 PDT, Kevin Watters	kevino: review+ kevino: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2010-05-03 12:34:01 PDT

Attachment 54953 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/wx/MainThreadWx.cpp:33: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/wtf/wx/MainThreadWx.cpp:36: wxEVT_CALL_AFTER is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/wtf/wx/MainThreadWx.cpp:39: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kevin Ollivier

Comment 2 2010-05-03 12:39:46 PDT

These style issues are due to conflict with wx header and naming conventions, so I'm approving this patch.

Kevin Ollivier

Comment 3 2010-05-03 15:37:56 PDT

Landed in r58709, thanks!

Note You need to log in before you can comment on or make changes to this bug.