[chromium] right clicks should not close select popup

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jay Civelli]

- Open a select popup
- Right click in the page (or on the select itself)

Expected:
- the select popup stays open

Actual:
- the select popup is closed

[Jay Civelli]

Created attachment 54944 [details]
Don't hide popup on right and middle mouse click

[WebKit Review Bot]

Attachment 54944 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 54944 [details]
Don't hide popup on right and middle mouse click

This seems fine except for the tab in the changelog noted by the stylebot, so this won't commit cleanly in this state.

If you were a WebKit committer, I'd give you an r+ but due to the TAB and the non-committer status r-.

[Jay Civelli]

Created attachment 54973 [details]
Fixing style

[WebKit Commit Bot]

Comment on attachment 54973 [details]
Fixing style

Clearing flags on attachment: 54973

Committed r58757: <http://trac.webkit.org/changeset/58757>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/58757 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58756
http://trac.webkit.org/changeset/58757