Bug 38473 - [chromium] right clicks should not close select popup
Summary: [chromium] right clicks should not close select popup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-03 11:11 PDT by Jay Civelli
Modified: 2010-05-04 07:57 PDT (History)
4 users (show)

See Also:


Attachments
Don't hide popup on right and middle mouse click (1.48 KB, patch)
2010-05-03 11:25 PDT, Jay Civelli
levin: review-
Details | Formatted Diff | Diff
Fixing style (1.49 KB, patch)
2010-05-03 16:50 PDT, Jay Civelli
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-05-03 11:11:00 PDT
- Open a select popup
- Right click in the page (or on the select itself)

Expected:
- the select popup stays open

Actual:
- the select popup is closed
Comment 1 Jay Civelli 2010-05-03 11:25:54 PDT
Created attachment 54944 [details]
Don't hide popup on right and middle mouse click
Comment 2 WebKit Review Bot 2010-05-03 11:27:41 PDT
Attachment 54944 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Levin 2010-05-03 16:33:49 PDT
Comment on attachment 54944 [details]
Don't hide popup on right and middle mouse click

This seems fine except for the tab in the changelog noted by the stylebot, so this won't commit cleanly in this state.

If you were a WebKit committer, I'd give you an r+ but due to the TAB and the non-committer status r-.
Comment 4 Jay Civelli 2010-05-03 16:50:43 PDT
Created attachment 54973 [details]
Fixing style
Comment 5 WebKit Commit Bot 2010-05-04 07:04:56 PDT
Comment on attachment 54973 [details]
Fixing style

Clearing flags on attachment: 54973

Committed r58757: <http://trac.webkit.org/changeset/58757>
Comment 6 WebKit Commit Bot 2010-05-04 07:05:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-05-04 07:57:31 PDT
http://trac.webkit.org/changeset/58757 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58756
http://trac.webkit.org/changeset/58757