Bug 3847

Summary: GW: add Cap support to QRegExp
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
a little more tricky than some, but should still be easily understandable mjs: review+

Description Eric Seidel (no email) 2005-07-04 01:37:31 PDT
The attached patch adds QRegExp::cap(int) support to KWQ.
Comment 1 Eric Seidel (no email) 2005-07-04 01:38:40 PDT
Created attachment 2785 [details]
a little more tricky than some, but should still be easily understandable
Comment 2 Maciej Stachowiak 2005-07-07 21:30:29 PDT
Comment on attachment 2785 [details]
a little more tricky than some, but should still be easily understandable

r=me

Make sure to test performance before landing.

minor style nitpick: we prefer no braces around single-line if bodies. Please
fix that before landing.
Comment 3 Maciej Stachowiak 2005-07-07 21:34:05 PDT
Comment on attachment 2785 [details]
a little more tricky than some, but should still be easily understandable

r=me

Make sure to test performance before landing.

minor style nitpick: we prefer no braces around single-line if bodies. Please
fix that before landing.
Comment 4 Eric Seidel (no email) 2005-07-08 18:07:23 PDT
I ran autovicki.  No performance regressions:

Before: cvs-base AvgCached:     0.144
After: cvs-base AvgCached:     0.144