Bug 38416

Summary: fast/repaint/fixed-move-after-keyboard-scroll passes on Leopard, fails on Snow Leopard
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 38964    
Bug Blocks:    
Attachments:
Description Flags
Patch none

James Robinson
Reported 2010-04-30 18:24:15 PDT
fast/repaint/fixed-move-after-keyboard-scroll passes on Leopard, fails on Snow Leopard
Attachments
Patch (1.44 KB, patch)
2010-04-30 18:33 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-04-30 18:28:50 PDT
This is a new test. It passes on Leopard and most other platforms WebKit runs on, but seems to fail on Snow Leopard. Based on the test output I suspect that the test is finishing before the test body runs. I've verified that the test passes when run manually. The test depends on eventSender.keyDown("pageDown") dispatching a synchronous scroll event. This is true on Leopard, but might not be true on Snow Leopard (perhaps due to fancy scroll animations or some such?). If this really is what is happening, it should be pretty easy to modify the test to work around this.
James Robinson
Comment 2 2010-04-30 18:30:14 PDT
I won't get a chance to look into this until next week, so I would like to add it to the SL skipped list until then.
James Robinson
Comment 3 2010-04-30 18:33:09 PDT
Created attachment 54843 [details] Patch
Eric Seidel (no email)
Comment 4 2010-05-01 21:53:54 PDT
Comment on attachment 54843 [details] Patch You should have just checked this in. it's impossible to CQ this since the tree is currently on fire because of this. Broken tree = very lame.
Eric Seidel (no email)
Comment 5 2010-05-01 22:07:35 PDT
Comment on attachment 54843 [details] Patch Clearing flags on attachment: 54843 Committed r58639: <http://trac.webkit.org/changeset/58639>
Eric Seidel (no email)
Comment 6 2010-05-01 22:07:49 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 7 2010-05-01 22:09:02 PDT
I'm very sad. The tree was needlessly red for over a day due to the original change. Total lame. Fixed now, I believe.
Simon Fraser (smfr)
Comment 8 2010-05-02 09:45:03 PDT
Sorry, I promised James I'd look at this bug other stuff came up.
James Robinson
Comment 9 2010-05-11 16:38:18 PDT
I now have access to a Snow Leopard machine (hurray!) am investigating this.
James Robinson
Comment 10 2010-05-11 18:52:34 PDT
This seems to boil down to smooth scrolling being on by default in Snow Leopard and off by default in Leopard. With "Use smooth scrolling" disabled in my System Preferences on Snow Leopard the test passes unmodified. The options are: - teach DRT how to turn smooth scrolling off when running layout tests - teach this test to detect when smooth scrolling is going on and accomodate it I think the first option is better.
Note You need to log in before you can comment on or make changes to this bug.