Bug 38382

Summary:

[Qt] Build error in GraphicsContext3DQt.cpp

Product:

WebKit

Reporter:

Jarkko Sakkinen <jarkko.j.sakkinen>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, noam

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Build fixes.	none

Jarkko Sakkinen

Reported 2010-04-30 02:02:49 PDT

- Noam made duplicate patch on isGLES2Compliant. After little thinking I think his patch does this in correct way and mine does in a wrong. Have to remove my implementation. - texImage2D/texSubImage2D API has been changed.

Attachments
Build fixes. (3.11 KB, patch) 2010-04-30 02:33 PDT, Jarkko Sakkinen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jarkko Sakkinen

Comment 1 2010-04-30 02:03:48 PDT

Noam, I'm submitting patch for this ASAP.

Noam Rosenthal

Comment 2 2010-04-30 02:06:52 PDT

Thanks Jarkko... I guess we had a mid-air collision on this :)

Jarkko Sakkinen

Comment 3 2010-04-30 02:33:05 PDT

Created attachment 54789 [details] Build fixes.

Jarkko Sakkinen

Comment 4 2010-04-30 02:33:25 PDT

Yeah, np :)

Eric Seidel (no email)

Comment 5 2010-04-30 11:43:28 PDT

Comment on attachment 54789 [details] Build fixes. LGTM.

WebKit Commit Bot

Comment 6 2010-05-02 05:05:29 PDT

Comment on attachment 54789 [details] Build fixes. Clearing flags on attachment: 54789 Committed r58651: <http://trac.webkit.org/changeset/58651>

WebKit Commit Bot

Comment 7 2010-05-02 05:05:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.