Bug 38375

Summary: Add codegen support for unsigned right shift
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2010-04-29 23:04:24 PDT
Add codegen support for unsigned right shift
Attachments
Patch (19.79 KB, patch)
2010-04-29 23:33 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-04-29 23:33:33 PDT
Created attachment 54785 [details] Patch
WebKit Review Bot
Comment 2 2010-04-29 23:35:40 PDT
Attachment 54785 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/assembler/MacroAssemblerARM.h:182: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/assembler/MacroAssemblerX86Common.h:253: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/assembler/X86Assembler.h:678: shrl_i8r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/assembler/X86Assembler.h:688: shrl_CLr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/assembler/MacroAssemblerARMv7.h:261: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2010-04-30 00:31:33 PDT
Comment on attachment 54785 [details] Patch r+ with comments in irc.
Oliver Hunt
Comment 4 2010-04-30 00:56:53 PDT
Committed r58562: <http://trac.webkit.org/changeset/58562>
Note You need to log in before you can comment on or make changes to this bug.