Bug 38363 – Handle double on righthand side of a right shift

• Component: New Bugs
• Status: RESOLVED FIXED

[Oliver Hunt]

Handle double on righthand side of a right shift

[Oliver Hunt]

Created attachment 54757 [details]
Patch

[Oliver Hunt]

Created attachment 54760 [details]
Patch

[Gavin Barraclough]

Comment on attachment 54760 [details]
Patch

I think the if/else cases could be a little clearer if you structured them like this:

if (isOperandConstantImmediateInt(op2)) {
    // ...
    // ... (1 slow case to link), (optimization goes here!)
    // ...
} else if (isOperandConstantImmediateInt(op1)) {
    // ...
    // ... (1 slow case to link)
    // ...
} else { // !isOperandConstantImmediateInt(op1) && !isOperandConstantImmediateInt(op2)
    // ...
    // ... (2 slow cases to link), (optimization goes here!)
    // ...
}

buts that's personal taste, r+ either way.

[Oliver Hunt]

Committed r58555: <http://trac.webkit.org/changeset/58555>