Bug 38352

Summary: Need to updateLayout after typing commands too
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch adele: review+

Justin Garcia
Reported 2010-04-29 14:33:43 PDT
In EditCommand::apply(), unapply() and reapply(), we do an updateLayout in case the editing operation doesn't do it itself. We should provide this convenience for typing commands, too. Text insertion is part of some open typing command, and they don't go through these functions, but all high level editing operations go through Editor::appliedEditing, unappliedEditing and reappliedEditing. We should move the updateLayout there.
Attachments
patch (5.18 KB, patch)
2010-04-29 15:59 PDT, Justin Garcia 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2010-04-29 15:59:20 PDT
Created attachment 54746 [details] patch
Enrica Casucci
Comment 2 2010-04-29 16:39:39 PDT
Looks good to me.
Justin Garcia
Comment 3 2010-04-29 16:52:39 PDT
Comment on attachment 54746 [details] patch enrica r+d this over email
Justin Garcia
Comment 4 2010-04-29 16:55:20 PDT
Comment on attachment 54746 [details] patch Oops Enrica doesn't have r+ privs yet, resetting the review flag.
Adele Peterson
Comment 5 2010-04-29 16:59:52 PDT
Comment on attachment 54746 [details] patch looks fine.
Justin Garcia
Comment 6 2010-04-29 17:51:32 PDT
trac.webkit.org/projects/webkit/changeset/58551
Note You need to log in before you can comment on or make changes to this bug.