Summary: | Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Ollivier <kevino> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, eric, playmobil, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Kevin Ollivier
2010-04-29 10:53:54 PDT
Created attachment 54719 [details]
Patch
This is needed so that wx can compile and use ComplexTextController, BTW. Comment on attachment 54719 [details]
Patch
This should be done by svn cp’ing SimpleFontDataMac.mm to the two new files and removing everything but the needed methods, includes and copyright headers. The #if USE()s should go outside the namespace and the second paragraph of #includes.
Created attachment 54747 [details]
Patch
Attachment 54747 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:48: Use 0 instead of NULL. [readability/null] [5]
WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:74: Use 0 instead of NULL. [readability/null] [5]
WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:81: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 54747 [details]
Patch
Is there a reason why you didn’t address my second feedback item, regarding the placement of the #if directives?
Created attachment 54749 [details]
Patch
(In reply to comment #6) > (From update of attachment 54747 [details]) > Is there a reason why you didn’t address my second feedback item, regarding the > placement of the #if directives? Oops, sorry, no, I just got caught up in redoing the patch and forgot about it. I'll fix and re-upload. Created attachment 54751 [details]
Patch
The patch was committed as r58557, and rolled out by r58560 because of compile errors on Tiger, Leopard, and Chromium/Mac. (In reply to comment #10) > The patch was committed as r58557, and rolled out by r58560 because of compile > errors on Tiger, Leopard, and Chromium/Mac. Correction: Tiger was ok. Leopard and Chromium/Mac failed. I haven't looked into the compile failures but FYI Chromium compiles with both the ATSUI & Core text functionality enabled and switches the APIs used at runtime. This, as opposed to other ports that make the decision at compile time. http://trac.webkit.org/changeset/58581 might have broken Chromium Mac Release |