|Summary:||Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.|
|Product:||WebKit||Reporter:||Kevin Ollivier <kevino>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, eric, playmobil, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Kevin Ollivier 2010-04-29 10:53:54 PDT
Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
Comment 2 Kevin Ollivier 2010-04-29 11:25:02 PDT
This is needed so that wx can compile and use ComplexTextController, BTW.
Comment 3 mitz 2010-04-29 11:28:47 PDT
Comment on attachment 54719 [details] Patch This should be done by svn cp’ing SimpleFontDataMac.mm to the two new files and removing everything but the needed methods, includes and copyright headers. The #if USE()s should go outside the namespace and the second paragraph of #includes.
Comment 5 WebKit Review Bot 2010-04-29 16:03:42 PDT
Attachment 54747 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:48: Use 0 instead of NULL. [readability/null]  WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:74: Use 0 instead of NULL. [readability/null]  WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:81: Use 0 instead of NULL. [readability/null]  Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 mitz 2010-04-29 16:05:33 PDT
Comment on attachment 54747 [details] Patch Is there a reason why you didn’t address my second feedback item, regarding the placement of the #if directives?
Comment 8 Kevin Ollivier 2010-04-29 16:08:51 PDT
(In reply to comment #6) > (From update of attachment 54747 [details]) > Is there a reason why you didn’t address my second feedback item, regarding the > placement of the #if directives? Oops, sorry, no, I just got caught up in redoing the patch and forgot about it. I'll fix and re-upload.
Comment 10 Kent Tamura 2010-04-29 23:48:07 PDT
Comment 11 Kent Tamura 2010-04-29 23:49:49 PDT
(In reply to comment #10) > The patch was committed as r58557, and rolled out by r58560 because of compile > errors on Tiger, Leopard, and Chromium/Mac. Correction: Tiger was ok. Leopard and Chromium/Mac failed.
Comment 12 Jeremy Moskovich 2010-04-30 04:44:39 PDT
I haven't looked into the compile failures but FYI Chromium compiles with both the ATSUI & Core text functionality enabled and switches the APIs used at runtime. This, as opposed to other ports that make the decision at compile time.
Comment 13 WebKit Review Bot 2010-04-30 09:51:13 PDT
http://trac.webkit.org/changeset/58581 might have broken Chromium Mac Release