Bug 38312

Summary:

Add sqrt support for ARM port

Product:

WebKit

Reporter:

Zoltan Herczeg <zherczeg>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, eric, loki, oliver, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	oliver: review+, commit-queue: commit-queue-

Zoltan Herczeg

Reported 2010-04-29 00:57:14 PDT

Patch for sqrt support

Attachments
patch (2.95 KB, patch) 2010-04-29 01:03 PDT, Zoltan Herczeg	oliver: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zoltan Herczeg

Comment 1 2010-04-29 01:03:35 PDT

Created attachment 54680 [details] patch

WebKit Review Bot

Comment 2 2010-04-29 01:04:58 PDT

Attachment 54680 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/assembler/ARMAssembler.h:430: fsqrtd_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2010-04-29 06:42:32 PDT

Comment on attachment 54680 [details] patch Rejecting patch 54680 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html

Zoltan Herczeg

Comment 4 2010-04-29 07:54:40 PDT

> Found no modified ChangeLogs, cannot create a commit message. There IS a ChangeLog in the patch, bot. Anyway, landed in r58515

Eric Seidel (no email)

Comment 5 2010-04-29 08:38:24 PDT

I suspect there may be an error in the date line. Webkit-patch commit-message can tell you.

Eric Seidel (no email)

Comment 6 2010-05-06 23:25:56 PDT

Turns out there was a regression in svn-apply. cjersonek fixed.

Note You need to log in before you can comment on or make changes to this bug.