Bug 38288

Summary: [chromium] revert getFontDataForCharacters change in r58341
Product: WebKit Reporter: Evan Martin <evan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agl
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch levin: review+

Evan Martin
Reported 2010-04-28 15:24:42 PDT
[chromium] revert getFontDataForCharacters change
Attachments
Patch (4.62 KB, patch)
2010-04-28 15:26 PDT, Evan Martin 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2010-04-28 15:26:32 PDT
Created attachment 54629 [details] Patch
Evan Martin
Comment 2 2010-04-28 15:28:25 PDT
We hit this code path repeatedly while rendering. It wasn't so bad before (since it was just computing a font name) but it is very bad now (since we're loading a font).
Adam Langley
Comment 3 2010-04-28 15:32:36 PDT
LGTM. (I think a rollout is permitted without a real WebKit review so you could just land this now.)
Evan Martin
Comment 4 2010-04-28 17:38:47 PDT
Committed r58447: <http://trac.webkit.org/changeset/58447>
Note You need to log in before you can comment on or make changes to this bug.