| Summary: | Audit all uses of subprocess in webkitpy | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, tony | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2010-04-28 14:24:15 PDT
Created attachment 54621 [details]
Patch
Comment on attachment 54621 [details] Patch Two things to fix up before committing. > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > + in webkitpy. I did not find any unsafe calls > + in my audit, but I did remove numerousunneeded numerousunneeded > > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py > - rcode = subprocess.call(['wdiff'], stderr=f) > + # We're ignoring the return and always returning True > + self._executive.run_command(['wdiff'], error_handler=Excutive.ignore_error) Excutive You mentioned possibly adding a test for this? It may be good if you could because it would have caught this issue. Created attachment 54624 [details]
Now with a unittest
Committed r58434: <http://trac.webkit.org/changeset/58434> |