Bug 3826 – GW: Add defs to KWQDefs

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

These defs are necessary for compiling kdom, and other products on top of KWQ.

[Eric Seidel (no email)]

Created attachment 2765 [details]
Adds a few defs to KWQDefs

This patch also removes the Q_UNUSED(a) hack, or at least changes the
implementation thereof.  The previous implementation did not work with unused
"const" arguments.   At least not under GCC 4.0

[Maciej Stachowiak]

Comment on attachment 2765 [details]
Adds a few defs to KWQDefs

> +typedef __int64_t Q_INT64;
> +typedef __uint64_t Q_UINT64;

Suggest using int64_t and uint_64_t with no underscores instead.

Regarding QMAX/QMIN and KMAX/KMIN, I think it would be better to port the
relevant code to kMax kMin, since that's the direction KHTML went, but failing
that, at least use the typesafe version for QMAX/QMIN.

> +#define qRound(a) lround(a)

Suggest an inline function instead of a macro.

[Eric Seidel (no email)]

Created attachment 2783 [details]
fixes mjs's concerns

[Maciej Stachowiak]

Comment on attachment 2783 [details]
fixes mjs's concerns

r=me

[Geoffrey Garen]

Comment on attachment 2783 [details]
fixes mjs's concerns

this patch fails to build

[Geoffrey Garen]

Created attachment 2819 [details]
patch to fix failed build

This patch will build successfully

[Eric Seidel (no email)]

Comment on attachment 2783 [details]
fixes mjs's concerns

ggaren, can I get a log message, or a reason?  This patch builds for me just
fine.  I'm using gcc 4.0

[Eric Seidel (no email)]

The build failure was only on 3.3 (which Apple internal is the only one left using).

[Geoffrey Garen]

Created attachment 2821 [details]
patch that builds w/gcc 3.3

This version of the patch builds successfully w/gcc 3.3

[Maciej Stachowiak]

Comment on attachment 2821 [details]
patch that builds w/gcc 3.3

r=me