Bug 38254

Summary:

Regression on fast/text/international/khmer-selection.html

Product:

WebKit

Reporter:

Marcus Bulach <bulach>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

bulach, commit-queue, jamesr, jorlow, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Marcus Bulach

Reported 2010-04-28 04:40:46 PDT

Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html

Attachments
Patch (9.46 KB, patch) 2010-04-28 04:42 PDT, Marcus Bulach	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Marcus Bulach

Comment 1 2010-04-28 04:42:29 PDT

Created attachment 54548 [details] Patch

WebKit Review Bot

Comment 2 2010-04-28 04:45:33 PDT

Attachment 54548 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp:142: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jeremy Orlow

Comment 3 2010-04-28 04:46:18 PDT

Comment on attachment 54548 [details] Patch r=me Leave this bug open after you commit to track the fact that this has been reverted.

WebKit Commit Bot

Comment 4 2010-04-28 04:58:53 PDT

Comment on attachment 54548 [details] Patch Clearing flags on attachment: 54548 Committed r58404: <http://trac.webkit.org/changeset/58404>

WebKit Commit Bot

Comment 5 2010-04-28 04:58:58 PDT

All reviewed patches have been landed. Closing bug.

James Robinson

Comment 6 2010-05-03 17:55:51 PDT

Reverting a patch is fine, but when you do please reopen the original bug or at least CC the original patch author. I didn't know this was reverted until I saw that the same errors were showing up.

James Robinson

Comment 7 2010-05-03 18:01:05 PDT

Ah, you did CC me. However the bugzilla emails never mentioned reverting anything. Please do reopen the original bug when reverting a patch in the future. Do you happen to remember what the failures were or what platforms they occurred on?

Jeremy Orlow

Comment 8 2010-05-04 02:15:17 PDT

Sorry...this got mixed up with a lot of other failures those days. I think I was going to land by hand and then changed my mind to commit bot forgetting that it needed to stay open. I thought I documented somewhere why this was reverted, but now I can't find it, and I can't remember. I guess maybe commit again while giving the gardener a heads up? Sorry.

Jeremy Orlow

Comment 9 2010-05-04 02:15:41 PDT

Re-opening to track.

Marcus Bulach

Comment 10 2010-05-04 03:19:48 PDT

Sorry James, I should've reopened the original bug and added more info here, my bad.. IIRC, the problem was linux only: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=khmer-selection.html

Note You need to log in before you can comment on or make changes to this bug.