Bug 38235

Summary: Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, fishd, kbr, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
revised patch : responding to Ken Russell's review
none
revised patch: remove the -image postfix none

Zhenyao Mo
Reported 2010-04-27 17:27:22 PDT
extractImageData should happen in WebGLRenderingContext so we can track format/internalformat/etc. for conformance.
Attachments
patch (19.57 KB, patch)
2010-04-27 19:10 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
revised patch : responding to Ken Russell's review (20.49 KB, patch)
2010-04-28 11:03 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
revised patch: remove the -image postfix (20.27 KB, patch)
2010-04-28 11:27 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-04-27 19:10:31 PDT
Created attachment 54503 [details] patch
Kenneth Russell
Comment 2 2010-04-27 19:21:49 PDT
Comment on attachment 54503 [details] patch Thanks for fixing this. Overall it looks good. Could you add a helper texImage2D/texSubImage2D taking an Image* and refactor the versions taking HTMLCanvasElement, HTMLImageElement and HTMLVideoElement in terms of it to share more code? Also, could you name the new routines tex{Sub}Image2DBase or tex{Sub}Image2DImpl? Changing the beginning of the method name is confusing.
Zhenyao Mo
Comment 3 2010-04-28 11:03:09 PDT
Created attachment 54588 [details] revised patch : responding to Ken Russell's review
Kenneth Russell
Comment 4 2010-04-28 11:13:30 PDT
Comment on attachment 54588 [details] revised patch : responding to Ken Russell's review Please just use overloaded methods for texImage2DImage and texSubImage2DImage -- i.e., drop the "Image" suffix. The "Base" version is fine. Thanks.
Zhenyao Mo
Comment 5 2010-04-28 11:27:03 PDT
Created attachment 54593 [details] revised patch: remove the -image postfix
Kenneth Russell
Comment 6 2010-04-28 11:33:32 PDT
Comment on attachment 54593 [details] revised patch: remove the -image postfix Thanks, this is a nice cleanup. Looks good to me.
Dimitri Glazkov (Google)
Comment 7 2010-04-28 12:56:29 PDT
Comment on attachment 54593 [details] revised patch: remove the -image postfix rs=me.
WebKit Commit Bot
Comment 8 2010-04-29 00:42:21 PDT
Comment on attachment 54593 [details] revised patch: remove the -image postfix Clearing flags on attachment: 54593 Committed r58481: <http://trac.webkit.org/changeset/58481>
WebKit Commit Bot
Comment 9 2010-04-29 00:42:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.