Summary: | [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Cheng <dcheng> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jianli | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Attachments: |
|
Description
Daniel Cheng
2010-04-27 16:08:19 PDT
Created attachment 54468 [details]
Filter file:// URLs from event.dataTransfer.getData
Created attachment 54470 [details]
Filter file:// URLs from event.dataTransfer.getData
Fix incorrect permissions on WebCore/ChangeLog
Comment on attachment 54470 [details]
Filter file:// URLs from event.dataTransfer.getData
WebCore/ChangeLog:5
+ [Chromium] Filter out URLs with file:// scheme from text/uri-list when dragging.
Can you update the bug title in order to be consistent with the line above. Also, I think you could simply say "file scheme".
WebCore/platform/chromium/ClipboardChromium.cpp:170
+ if (protocolIs(uri, "file"))
Could you please add a comment for doing this?
WebCore/platform/chromium/ClipboardChromium.cpp:185
+ if (!m_dataObject->url.isEmpty() && !m_dataObject->url.isLocalFile()) {
ditto.
WebCore/platform/chromium/ClipboardChromium.cpp:321
+ if (m_dataObject->url.isValid() && !m_dataObject->url.isLocalFile()) {
ditto.
Created attachment 54486 [details]
Filter file URLs from event.dataTransfer.getData
Comment on attachment 54486 [details]
Filter file URLs from event.dataTransfer.getData
r=me
Comment on attachment 54486 [details] Filter file URLs from event.dataTransfer.getData Clearing flags on attachment: 54486 Committed r58378: <http://trac.webkit.org/changeset/58378> All reviewed patches have been landed. Closing bug. |