Bug 3822

Summary: GW: Add necessary forwarding headers
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
necessary forwarding headers, as described in the bug.
mjs: review-
new patch (as a patch now) w/o values.h mjs: review+

Eric Seidel (no email)
Reported 2005-07-02 19:28:05 PDT
These additional forwarding headers are required to support compiling other products against KWQ: kinstance.h - #import "KWQKInstance.h" qdir.h - empty qglobal.h - empty values.h - empty kio/netaccess.h - empty kjs/scope_chain.h - #import <JavaScriptCore/scope_chain.h>
Attachments
necessary forwarding headers, as described in the bug. (309 bytes, application/x-gzip)
2005-07-02 19:28 PDT, Eric Seidel (no email) 		mjs: review-
Details
new patch (as a patch now) w/o values.h (936 bytes, patch)
2005-07-03 15:16 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-07-02 19:28:40 PDT
Created attachment 2760 [details] necessary forwarding headers, as described in the bug.
Maciej Stachowiak
Comment 2 2005-07-03 03:05:30 PDT
I suggest not putting in values.h since we don't usually use the empty file hack for system headers, just for Qt/KDE headers that we lack. It's also better to use the constants from limits.h instead.
Eric Seidel (no email)
Comment 3 2005-07-03 14:21:59 PDT
It turns out that they include values.h for "DBL_MAX" which is found in "float.h" on our system. I'll #ifdef the include.
Eric Seidel (no email)
Comment 4 2005-07-03 14:25:34 PDT
It turns out that they include values.h for "DBL_MAX" which is found in "float.h" on our system. I'll #ifdef the include.
Eric Seidel (no email)
Comment 5 2005-07-03 15:13:57 PDT
Actually float.h exists on linux, so we've changed the source to use that instead of values.h
Eric Seidel (no email)
Comment 6 2005-07-03 15:16:57 PDT
Created attachment 2777 [details] new patch (as a patch now) w/o values.h
Note You need to log in before you can comment on or make changes to this bug.