Bug 38218
| Summary: | webkit-patch upload --no-review should imply --no-obsolete | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, cjerdonek, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Ojan Vafai
If you are putting a patch up for non-review, it's unlikely that you want it to obsolete previous patches you've put up for review. It just removed an r+ from a reviewed patch because I uploaded a different patch with --no-review.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I see the flags as unrelated. However I can certainly see this use case. So long as you update the help I'd be OK with it.
Eric Seidel (no email)
We you uploading a new patch to have it landed via the commit queue?
That case is already supported by "land-safely" explicitly.
Adam Barth
We should show land-safely in the main help.
Ojan Vafai
(In reply to comment #2)
> We you uploading a new patch to have it landed via the commit queue?
> That case is already supported by "land-safely" explicitly.
No. I was uploading a new patch that I committed without review.
I would use post, but I wanted prepare-ChangeLog to be called with the right arguments, and incidentally, to get the other benefits of upload (check-webkit-style, etc).
Ojan Vafai
FWIW, I don't feel too strongly about this. I was just surprised that non-review patches would also obsolete.