Bug 3821

Summary:

GW: add KWQWMatrix white-room implementation

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

3250

Attachments:

Description	Flags
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h	mjs: review-
Fixes the two issues mjs raised	mjs: review+
project file diff	mjs: review+

Description Eric Seidel (no email) 2005-07-02 18:47:02 PDT

Attached is my white-room implementation of KWQWMatrix.  It's very simple and uses CGAffineTransform 
for everything.  But it's enough to get other projects up and running correctly on KWQ.

Comment 1 Eric Seidel (no email) 2005-07-02 20:04:01 PDT

Created attachment 2761 [details]
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h

Comment 2 Maciej Stachowiak 2005-07-03 03:47:44 PDT

Comment on attachment 2761 [details]
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h

Seems like both your comments here are right. QWMatrix indeed takes degrees
while CGAffineTransform takes radians. And the behavior of invert() on a
singular matrix would not match between Qt and CG.

Comment 3 Eric Seidel (no email) 2005-07-03 15:09:12 PDT

Created attachment 2776 [details]
Fixes the two issues mjs raised

Comment 4 Eric Seidel (no email) 2005-07-05 00:33:49 PDT

Created attachment 2801 [details]
project file diff

Comment 5 Maciej Stachowiak 2005-07-05 01:39:27 PDT

Comment on attachment 2801 [details]
project file diff

r=me assuming you tested