Bug 38209
| Summary: | commands/steps should use a tighter mock for options | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, cjerdonek, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Ojan Vafai
[11:39am] abarth: the real issue
[11:39am] abarth: is that we use a very loose mock for options
[11:39am] abarth: the right thing to do
[11:39am] abarth: is to use a much tighter mock
[11:39am] abarth: that's an easy change
[11:40am] abarth: in commandtest.py
[11:40am] abarth: options=Mock()
[11:40am] abarth: which means we assume that every option can be read
[11:40am] abarth: when running the command
[11:40am] abarth: instead
[11:40am] abarth: we should compute which options will actually exist
[11:40am] abarth: from the |command|
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |