Bug 38207

Summary: [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dimich, jianli, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch jianli: review+, jianli: commit-queue-

Kinuko Yasuda
Reported 2010-04-27 11:32:10 PDT
Recently we introduced '|' as OR conditional (like '&' for AND) and v8's DerivedSources generation also needs to support it. See bug 37998 for details.
Attachments
Patch (1.46 KB, patch)
2010-04-27 11:56 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (2.06 KB, patch)
2010-04-27 11:59 PDT, Kinuko Yasuda 		jianli: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2010-04-27 11:56:25 PDT
Created attachment 54438 [details] Patch
Kinuko Yasuda
Comment 2 2010-04-27 11:59:12 PDT
Created attachment 54439 [details] Patch
Kinuko Yasuda
Comment 3 2010-04-27 12:02:21 PDT
The proposed patch worked for me in my chromium build with FileError.idl, that has OR '|' in its definition.
Yaar Schnitman
Comment 4 2010-04-27 14:28:46 PDT
LGTM though I'm not a reviewer.
Jian Li
Comment 5 2010-04-27 14:42:01 PDT
Comment on attachment 54439 [details] Patch r=me Please land with the following fix. WebCore/WebCore.gyp/scripts/action_derivedsourcesallinone.py:85 + # Wraps conditional with ENABLE() and && if more than one conditional is specified. Please update the comment.
Kinuko Yasuda
Comment 6 2010-04-27 16:24:35 PDT
Committed r58352: <http://trac.webkit.org/changeset/58352>
Note You need to log in before you can comment on or make changes to this bug.