|Summary:||[V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py|
|Product:||WebKit||Reporter:||Kinuko Yasuda <kinuko>|
|Component:||WebKit Misc.||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||dglazkov, dimich, jianli, yaar|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Kinuko Yasuda 2010-04-27 11:32:10 PDT
Recently we introduced '|' as OR conditional (like '&' for AND) and v8's DerivedSources generation also needs to support it. See bug 37998 for details.
Comment 3 Kinuko Yasuda 2010-04-27 12:02:21 PDT
The proposed patch worked for me in my chromium build with FileError.idl, that has OR '|' in its definition.
Comment 4 Yaar Schnitman 2010-04-27 14:28:46 PDT
LGTM though I'm not a reviewer.
Comment 5 Jian Li 2010-04-27 14:42:01 PDT
Comment on attachment 54439 [details] Patch r=me Please land with the following fix. WebCore/WebCore.gyp/scripts/action_derivedsourcesallinone.py:85 + # Wraps conditional with ENABLE() and && if more than one conditional is specified. Please update the comment.